Review Request: make folderview compile with Qt 4.7
Ralf Jung
ralfjung-e at gmx.de
Mon Feb 20 18:16:31 GMT 2012
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104030/
-----------------------------------------------------------
(Updated Feb. 20, 2012, 6:16 p.m.)
Review request for KDE Base Apps.
Changes
-------
- Fixed Q_ASSERT block
- avoid deeply nested return
I personally find a nested return more readable than first collecting the index, and only then using it, but here you go. And of course you were right, the Q_ASSERT was in the wrong block *oops*
Description
-------
Currently, kde-baseapps does not compile against Qt 4.7, in contrast to what cmake checks. This patch fixes the only place where Qt 4.8 API was used.
Diffs (updated)
-----
plasma/applets/folderview/actionoverlay.cpp 791cfdf
Diff: http://git.reviewboard.kde.org/r/104030/diff/
Testing
-------
compile-tested
Thanks,
Ralf Jung
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120220/23758ce9/attachment.htm>
More information about the kde-core-devel
mailing list