Review Request: Report file errors when extracting files using karchive

[Mario Bensi]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103808/#review10596
-----------------------------------------------------------


If you can, i prefer you use an enum Error (you need to create this) in class KArchiveFile and KArchiveDirectory and return this with a method "error" or "lastError" to check if all is ok or not. And why not change "void copyTo..." by "bool copyTo..." when the copyTo return false you can check why you have this error with "(last)Error".

- Mario Bensi


On Jan. 28, 2012, 4:46 p.m., Theofilos Intzoglou wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103808/
> -----------------------------------------------------------
> 
> (Updated Jan. 28, 2012, 4:46 p.m.)
> 
> 
> Review request for kdelibs.
> 
> 
> Description
> -------
> 
> A simple patch to check if something goes wrong when extracting files from an archive. You can read the error code using copyToErrorCode()
> 
> 
> Diffs
> -----
> 
>   kdecore/io/karchive.h 7cd7c0c 
>   kdecore/io/karchive.cpp 86d61d5 
> 
> Diff: http://git.reviewboard.kde.org/r/103808/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Theofilos Intzoglou
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120213/0e53329d/attachment.htm>