<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103808/">http://git.reviewboard.kde.org/r/103808/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">If you can, i prefer you use an enum Error (you need to create this) in class KArchiveFile and KArchiveDirectory and return this with a method "error" or "lastError" to check if all is ok or not. And why not change "void copyTo..." by "bool copyTo..." when the copyTo return false you can check why you have this error with "(last)Error".</pre>
<br />
<p>- Mario</p>
<br />
<p>On January 28th, 2012, 4:46 p.m., Theofilos Intzoglou wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for kdelibs.</div>
<div>By Theofilos Intzoglou.</div>
<p style="color: grey;"><i>Updated Jan. 28, 2012, 4:46 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">A simple patch to check if something goes wrong when extracting files from an archive. You can read the error code using copyToErrorCode()</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kdecore/io/karchive.h <span style="color: grey">(7cd7c0c)</span></li>
<li>kdecore/io/karchive.cpp <span style="color: grey">(86d61d5)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103808/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>