Review Request: try fix tooltip shadow problem

[Thomas Lübking]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107905/#review23982
-----------------------------------------------------------


Seems to be an insufficient repaint area - pot. related to bug #312168.

Wild guess from your patch: don't remove the shadows before, but *after* the hiding (eventually "later", ie. in the deconstructor or on the destroyed signal) to avoid confusations between the deleted window size and the "dirty" area.

- Thomas Lübking


On Dec. 25, 2012, 12:14 a.m., Xuetian Weng wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107905/
> -----------------------------------------------------------
> 
> (Updated Dec. 25, 2012, 12:14 a.m.)
> 
> 
> Review request for kdelibs, Plasma and Aaron J. Seigo.
> 
> 
> Description
> -------
> 
> Well. I'm not an expert in kwin related stuff, this patch is basically revert 157a06e46f46ba83ba37a93b400647f4886e18c9, but I don't know the real reason for that.
> 
> And actually, remove by handle is not necessary, since dialogshadows already connect to the widget's destroyed signal, hence it will handle that gracefully.
> 
> 
> This addresses bug 311502.
>     http://bugs.kde.org/show_bug.cgi?id=311502
> 
> 
> Diffs
> -----
> 
>   plasma/tooltipmanager.cpp 00bfcdb 
> 
> Diff: http://git.reviewboard.kde.org/r/107905/diff/
> 
> 
> Testing
> -------
> 
> seems it fixed, but not sure it's the right way.
> 
> 
> Thanks,
> 
> Xuetian Weng
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20121225/8292901a/attachment.htm>
-------------- next part --------------
_______________________________________________
Plasma-devel mailing list
Plasma-devel at kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel