Review Request: try fix tooltip shadow problem

Xuetian Weng wengxt at gmail.com
Tue Dec 25 00:14:10 GMT 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107905/
-----------------------------------------------------------

(Updated Dec. 25, 2012, 12:14 a.m.)


Review request for kdelibs, Plasma and Aaron J. Seigo.


Description
-------

Well. I'm not an expert in kwin related stuff, this patch is basically revert 157a06e46f46ba83ba37a93b400647f4886e18c9, but I don't know the real reason for that.

And actually, remove by handle is not necessary, since dialogshadows already connect to the widget's destroyed signal, hence it will handle that gracefully.


This addresses bug 311502.
    http://bugs.kde.org/show_bug.cgi?id=311502


Diffs (updated)
-----

  plasma/tooltipmanager.cpp 00bfcdb 

Diff: http://git.reviewboard.kde.org/r/107905/diff/


Testing
-------

seems it fixed, but not sure it's the right way.


Thanks,

Xuetian Weng

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20121225/97a1b5b0/attachment.htm>
-------------- next part --------------
_______________________________________________
Plasma-devel mailing list
Plasma-devel at kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


More information about the kde-core-devel mailing list