Review Request: QML Plasma Components - fix for bug in ScrollBar anchoring

[Marco Martin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107622/#review23192
-----------------------------------------------------------

Ship it!


good catch, sorry for the late reply

- Marco Martin


On Dec. 7, 2012, 10:16 a.m., Sebastian Gottfried wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107622/
> -----------------------------------------------------------
> 
> (Updated Dec. 7, 2012, 10:16 a.m.)
> 
> 
> Review request for KDE Runtime, Burkhard Lück and Marco Martin.
> 
> 
> Description
> -------
> 
> Regarding the QML Plasma components:
> 
> The recent commit by Bernhard Lück checking whether anchoring of a ScrollBar is possible contains a subtle logic error. I think the intended behavior is to check whether the ScrollBar item's parent is the associated flickable itself or its parent. But because the check is done in "internalLoader", a child of the actual ScrollBar item on directly on this item's parent property, it checks whether the ScrollBar item is the flickable or its parent. The patch fixes this by doing the checks on 'scrollBar.parent'.
> 
> Feel free to discard that request if I'm mistaken.
> 
> 
> Diffs
> -----
> 
>   plasma/declarativeimports/plasmacomponents/qml/ScrollBar.qml 7464645 
> 
> Diff: http://git.reviewboard.kde.org/r/107622/diff/
> 
> 
> Testing
> -------
> 
> The checking logic broke some of the scroll bars in KTouch, now they work again.
> 
> 
> Thanks,
> 
> Sebastian Gottfried
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20121209/9882922f/attachment.htm>