<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/107622/">http://git.reviewboard.kde.org/r/107622/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">good catch, sorry for the late reply</pre>
<br />
<p>- Marco</p>
<br />
<p>On December 7th, 2012, 10:16 a.m., Sebastian Gottfried wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Runtime, Burkhard Lück and Marco Martin.</div>
<div>By Sebastian Gottfried.</div>
<p style="color: grey;"><i>Updated Dec. 7, 2012, 10:16 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Regarding the QML Plasma components:
The recent commit by Bernhard Lück checking whether anchoring of a ScrollBar is possible contains a subtle logic error. I think the intended behavior is to check whether the ScrollBar item's parent is the associated flickable itself or its parent. But because the check is done in "internalLoader", a child of the actual ScrollBar item on directly on this item's parent property, it checks whether the ScrollBar item is the flickable or its parent. The patch fixes this by doing the checks on 'scrollBar.parent'.
Feel free to discard that request if I'm mistaken.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The checking logic broke some of the scroll bars in KTouch, now they work again.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasma/declarativeimports/plasmacomponents/qml/ScrollBar.qml <span style="color: grey">(7464645)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/107622/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>