Review Request: Show removable media in Dolphin's "Copy To" and "Move To" context menus

[Kai Uwe Broulik]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102657/#review23030
-----------------------------------------------------------



lib/konq/konq_copytomenu.cpp
<http://git.reviewboard.kde.org/r/102657/#comment17601>

    Those would have to go. If we show the Places, which have Root and Home by default, there is no need for these anymore.



lib/konq/konq_copytomenu.cpp
<http://git.reviewboard.kde.org/r/102657/#comment17602>

    Why are the Places (root is understandable but not the Places) ifdef'd out on Windows?



lib/konq/konq_copytomenu.cpp
<http://git.reviewboard.kde.org/r/102657/#comment17604>

    imho the Bluetooth place should not be shown since we have that "Send via bluetooth" icon and I doubt that the Bluetooth entry will work in that menu



lib/konq/konq_copytomenu.cpp
<http://git.reviewboard.kde.org/r/102657/#comment17603>

    Can you ensure that devices are not shown duplicated (ie. from the Places and then from the Harddrive letters)


- Kai Uwe Broulik


On Dec. 4, 2012, 6:25 p.m., Rajeesh K Nambiar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102657/
> -----------------------------------------------------------
> 
> (Updated Dec. 4, 2012, 6:25 p.m.)
> 
> 
> Review request for Dolphin, KDE Base Apps and David Faure.
> 
> 
> Description
> -------
> 
> The most common usage for "{Copy,Move} To" dolphin context menus is that a user wants to copy/move a selected file to plugged in USB drive. Show the mounted removable media also along with "Root Folder" and recently used entries.
> 
> It would be nice to have "Places" sidebar instead of the current implementation, which includes Root Folder, Home Folder, Desktop Folder, other drives including removable media like USB drives etc. See bugs 140475, 251151 et al. This should also help in scenario where plugged in removable media is not automatically mounted (which is the default setup at least in Fedora). I couldn't find a way to easily extend that functionality, though.
> 
> 
> This addresses bug 251151.
>     http://bugs.kde.org/show_bug.cgi?id=251151
> 
> 
> Diffs
> -----
> 
>   lib/konq/konq_copytomenu.cpp ca1d963 
> 
> Diff: http://git.reviewboard.kde.org/r/102657/diff/
> 
> 
> Testing
> -------
> 
> Tested in KDE SC 4.7.0 in Fedora and also by another ArchLinux user.
> 
> 
> Screenshots
> -----------
> 
> Places without Devices
>   http://git.reviewboard.kde.org/r/102657/s/268/
> 
> 
> Thanks,
> 
> Rajeesh K Nambiar
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20121205/c9cfb30e/attachment.htm>