KDE-GTK-Config to KDEReview

[Aleix Pol]

On Thu, Nov 8, 2012 at 4:13 PM, Aleix Pol <aleixpol at kde.org> wrote:

> On Thu, Nov 8, 2012 at 3:47 PM, Pino Toscano <pino at kde.org> wrote:
>
>> Hi,
>>
>> thanks for the work you are putting in it, so far.
>>
>
> Thanks for your effort for having the best project in extragear as well. :)
>
>
>>
>> Alle lunedì 5 novembre 2012, Aleix Pol ha scritto:
>> > Some months ago I pushed this project quite intensively so that right
>> > now we have a stable KCM for editing the GTK settings. This is being
>> > used already in some distributions, so I think it should be moved to
>> > extragear/base.
>> >
>> > So here I open the process for kde:kde-gtk-config to move in
>> > extragear. Any thoughts?
>>
>> Looking at the installed files, I see:
>>
>> - stuff in $prefix/bin:
>>   - reload_gtk_apps
>>   - gtk_preview
>>   - gtk3_preview
>> those names are too generic for a global bin dir, what about giving them
>> a "kgc_" (kde gtk config) prefix and install them in libexec dir?
>> KStandardDirs::findExe will find them anyway, and this way the global
>> bin dir is not polluted
>>
> Done.
> I wanted to do that but I always forgot
>
>
>>
>> - the icon $prefix/share/icons/hicolor/48x48/apps/gtkconfig.png had a
>> too generic name for hicolor, I renamed it to kde-gtk-config.png
>>
> Ok, thanks!
>
>
>>
>> --
>> Pino Toscano
>>
>
>
Hii!
Since all the raised concerns were solved, I'll proceed and move
kde:kde-gtk-config to extragear/base.

Aleix
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20121205/efa55776/attachment.htm>