Review Request: Remove redundant SSL certificate hostname mismatch check in KIO::TCPSlaveBase

Commit Hook null at kde.org
Thu Aug 30 16:13:51 BST 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106268/#review18287
-----------------------------------------------------------


This review has been submitted with commit 802ff5e68e1288295461ea6964086fb9d7cec536 by Dawit Alemayehu to branch KDE/4.9.

- Commit Hook


On Aug. 29, 2012, 5:28 p.m., Dawit Alemayehu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106268/
> -----------------------------------------------------------
> 
> (Updated Aug. 29, 2012, 5:28 p.m.)
> 
> 
> Review request for kdelibs.
> 
> 
> Description
> -------
> 
> The attached patch removes the code that performs SSL certificate host name mismatch check in TCPSlaveBase. Since we do not connect to servers using IP address anymore, it is simply redundant to perform checks that are already done in Qt's SSL classes.
> 
> 
> Diffs
> -----
> 
>   kio/kio/tcpslavebase.cpp 3101bff 
> 
> Diff: http://git.reviewboard.kde.org/r/106268/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dawit Alemayehu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120830/932e7f61/attachment.htm>


More information about the kde-core-devel mailing list