Review Request: Remove redundant SSL certificate hostname mismatch check in KIO::TCPSlaveBase

[Richard J. Moore]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106268/#review18272
-----------------------------------------------------------

Ship it!


Ship It!

- Richard J. Moore


On Aug. 29, 2012, 5:28 p.m., Dawit Alemayehu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106268/
> -----------------------------------------------------------
> 
> (Updated Aug. 29, 2012, 5:28 p.m.)
> 
> 
> Review request for kdelibs.
> 
> 
> Description
> -------
> 
> The attached patch removes the code that performs SSL certificate host name mismatch check in TCPSlaveBase. Since we do not connect to servers using IP address anymore, it is simply redundant to perform checks that are already done in Qt's SSL classes.
> 
> 
> Diffs
> -----
> 
>   kio/kio/tcpslavebase.cpp 3101bff 
> 
> Diff: http://git.reviewboard.kde.org/r/106268/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dawit Alemayehu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120830/8d02d8cc/attachment.htm>