Review Request: Fix SSL SNI support in KTcpSocket

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106087/#review17783
-----------------------------------------------------------


This review has been submitted with commit df1f193ba792b3bd258254ab3f75d4e76b0d0524 by Dawit Alemayehu to branch KDE/4.9.

- Commit Hook


On Aug. 19, 2012, 6:09 p.m., Dawit Alemayehu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106087/
> -----------------------------------------------------------
> 
> (Updated Aug. 19, 2012, 6:09 p.m.)
> 
> 
> Review request for kdelibs.
> 
> 
> Description
> -------
> 
> The attached patch adds two missing and valid flag conversions from KTcpSocket::SslVersion to QSsl::SslProtocol in KTcpSocket's qSslProtocolFromK. This causes TLSv1 SNI support to fail in TcpSlaveBase because it was recently changed by me to use KTcpSocket::SecureProtocols by default.
> 
> 
> This addresses bug 304212.
>     http://bugs.kde.org/show_bug.cgi?id=304212
> 
> 
> Diffs
> -----
> 
>   kdecore/network/ktcpsocket.cpp 8da620a 
> 
> Diff: http://git.reviewboard.kde.org/r/106087/diff/
> 
> 
> Testing
> -------
> 
> Test site from the bug report: https://sni.velox.ch/
> 
> 
> Thanks,
> 
> Dawit Alemayehu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120821/22d993e3/attachment.htm>