Review Request: Fix SSL SNI support in KTcpSocket

Dawit Alemayehu adawit at kde.org
Sun Aug 19 19:09:36 BST 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106087/
-----------------------------------------------------------

Review request for kdelibs.


Description
-------

The attached patch adds two missing and valid flag conversions from KTcpSocket::SslVersion to QSsl::SslProtocol in KTcpSocket's qSslProtocolFromK. This causes TLSv1 SNI support to fail in TcpSlaveBase because it was recently changed by me to use KTcpSocket::SecureProtocols by default.


This addresses bug 304212.
    http://bugs.kde.org/show_bug.cgi?id=304212


Diffs
-----

  kdecore/network/ktcpsocket.cpp 8da620a 

Diff: http://git.reviewboard.kde.org/r/106087/diff/


Testing
-------

Test site from the bug report: https://sni.velox.ch/


Thanks,

Dawit Alemayehu

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120819/417dca01/attachment.htm>


More information about the kde-core-devel mailing list