Review Request: Fix multiple issues in colors KCM

[Jeremy Paul Whiting]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106066/#review17635
-----------------------------------------------------------

Ship it!


Ship It!

- Jeremy Paul Whiting


On Aug. 18, 2012, 12:36 a.m., Christoph Feck wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106066/
> -----------------------------------------------------------
> 
> (Updated Aug. 18, 2012, 12:36 a.m.)
> 
> 
> Review request for kdelibs and Jeremy Paul Whiting.
> 
> 
> Description
> -------
> 
> When the user changes a color, the colors KCM automatically switches to "Current" scheme, which is a kind of temporary unsaved scheme. When the user now hits "Apply", the colors are saved, but the saved name is still the name of the previously selected scheme. On next load, the colors of that scheme will be restored.
> 
> This patch addresses the following issues around this "Current" scheme entry, in order of their appearance in diff:
> - do not offer "Current" (or "Default") name for saving
> - update preview icon when a colors gets changed
> - write "Current" as scheme name, when the temporary theme is used (fixes bug)
> - upon loading the "Current" scheme, mark it as "needs saving"
> - update preview icon for "Current" scheme when it is applied
> 
> 
> This addresses bug 305350.
>     http://bugs.kde.org/show_bug.cgi?id=305350
> 
> 
> Diffs
> -----
> 
>   kcontrol/colors/colorscm.cpp 465a90c 
> 
> Diff: http://git.reviewboard.kde.org/r/106066/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Christoph Feck
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120818/e110591b/attachment.htm>