<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/106066/">http://git.reviewboard.kde.org/r/106066/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre>
<br />
<p>- Jeremy Paul</p>
<br />
<p>On August 18th, 2012, 12:36 a.m., Christoph Feck wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for kdelibs and Jeremy Paul Whiting.</div>
<div>By Christoph Feck.</div>
<p style="color: grey;"><i>Updated Aug. 18, 2012, 12:36 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">When the user changes a color, the colors KCM automatically switches to "Current" scheme, which is a kind of temporary unsaved scheme. When the user now hits "Apply", the colors are saved, but the saved name is still the name of the previously selected scheme. On next load, the colors of that scheme will be restored.
This patch addresses the following issues around this "Current" scheme entry, in order of their appearance in diff:
- do not offer "Current" (or "Default") name for saving
- update preview icon when a colors gets changed
- write "Current" as scheme name, when the temporary theme is used (fixes bug)
- upon loading the "Current" scheme, mark it as "needs saving"
- update preview icon for "Current" scheme when it is applied</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=305350">305350</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kcontrol/colors/colorscm.cpp <span style="color: grey">(465a90c)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/106066/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>