Review Request: Fix hang in kcm_useraccount

[Rolf Eike Beer]

> On Aug. 6, 2012, 4:55 p.m., Rolf Eike Beer wrote:
> > kdepasswd/kcm/chfnprocess.cpp, line 68
> > <http://git.reviewboard.kde.org/r/105895/diff/1/?file=76314#file76314line68>
> >
> >     Why unread the line if you read it again just 3 lines below? Why not just put the readline() below in an else clause?
> 
> Michael Palimaka wrote:
>     After further thought, will readLine() work correctly after readAll()? That is the reason I unread in the original diff.

Which may be absolutely true (no idea). But then it deserves a comment explaining why you do it, otherwise the next poor soul touching the code may do the same mistake again.


- Rolf Eike


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105895/#review16985
-----------------------------------------------------------


On Aug. 6, 2012, 5:03 p.m., Michael Palimaka wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105895/
> -----------------------------------------------------------
> 
> (Updated Aug. 6, 2012, 5:03 p.m.)
> 
> 
> Review request for KDE Base Apps.
> 
> 
> Description
> -------
> 
> When changing the user's full name, chfn may not necessarily produce any output. Since readLine blocks, the kcm may hang.
> 
> This change checks if chfn exited without output, and if so, use that exit status.
> 
> 
> This addresses bug 156396.
>     http://bugs.kde.org/show_bug.cgi?id=156396
> 
> 
> Diffs
> -----
> 
>   kdepasswd/kcm/chfnprocess.cpp 9f75d4aa75b41acec84e7798c789d4226ca3fab9 
> 
> Diff: http://git.reviewboard.kde.org/r/105895/diff/
> 
> 
> Testing
> -------
> 
> On a PAM-enabled system:
> * Full name changed successfully when permitted by login.defs
> * Error presented and no change processed with prohibited by login.defs
> 
> 
> Thanks,
> 
> Michael Palimaka
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120807/f369ed14/attachment.htm>