Review Request: Fix hang in kcm_useraccount

[Michael Palimaka]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105895/
-----------------------------------------------------------

(Updated Aug. 6, 2012, 5:03 p.m.)


Review request for KDE Base Apps.


Changes
-------

Updated diff as per comments.


Description
-------

When changing the user's full name, chfn may not necessarily produce any output. Since readLine blocks, the kcm may hang.

This change checks if chfn exited without output, and if so, use that exit status.


This addresses bug 156396.
    http://bugs.kde.org/show_bug.cgi?id=156396


Diffs (updated)
-----

  kdepasswd/kcm/chfnprocess.cpp 9f75d4aa75b41acec84e7798c789d4226ca3fab9 

Diff: http://git.reviewboard.kde.org/r/105895/diff/


Testing
-------

On a PAM-enabled system:
* Full name changed successfully when permitted by login.defs
* Error presented and no change processed with prohibited by login.defs


Thanks,

Michael Palimaka

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120806/3d170095/attachment.htm>