[PATCH] KSecretsService Collection and Item property names

Jakub Filak jfilak at redhat.com
Sun Aug 5 11:23:59 BST 2012


The current implementation of KSecretsService accepts property names of 
Collection and Item without interface name. The Secret Service API standard 
says "Specify the property names in full interface.Property form" [1]

The form required by the standard:
	"org.freedesktop.Secret.Item.Label"

The accepted form in KSecretsService:
	"Label"

(gnome-keyring accepts the properties only in full interface form)

The patch changes the accepted name form from single name form to full 
interface name form. The patch simply adds an interface prefix to each 
occurrence of a property name. (I used a helper macros because of DRY.)

The patch applies to the files:
 ksecretsserviced/frontend/secret/collection.cpp
 ksecretsserviced/frontend/secret/service.cpp
 ksecretsserviced/frontend/tests/servicetest.cpp


Regards,
Jakub


[1] : http://standards.freedesktop.org/secret-service/re02.html
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Collection-and-Item-property-names-in-full-interface.patch
Type: text/x-patch
Size: 6816 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120805/b32faf3f/attachment.bin>


More information about the kde-core-devel mailing list