Review Request: KJS/Grammar: Introduce new non-terminal IdentifierName, to handle keywords as PropertyName, in Memberexps and CallExpr

[Bernd Buschinski]

> On April 21, 2012, 3:47 p.m., Maks Orlovich wrote:
> > Hmm, you may have missed my reply on IRC, making this languish in the ether: I meant number of shift/reduce conflicts in the parser, as reported 
> > by bison. I am ashamed to admit that I am not able to detect LALR parsing ambiguities by inspection..

ok, as I finally got what this is about:

This patch does not change the number of conflicts shift/reduce, with and without this patch it says
conflicts: 1 shift/reduce

Will post another patch soon which fixes this shift/reduce conflict + other minor warnings


- Bernd


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104243/#review12765
-----------------------------------------------------------


On March 12, 2012, 9:03 p.m., Bernd Buschinski wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104243/
> -----------------------------------------------------------
> 
> (Updated March 12, 2012, 9:03 p.m.)
> 
> 
> Review request for kdelibs.
> 
> 
> Description
> -------
> 
> KJS/Grammar: Introduce new non-terminal IdentifierName,
> which allows keywords to be used as PropertyName, in Memberexps and CallExpr.
> (but not yet enum,export,extends, super, because they have the same value RESERVED)
> 
> 
> Diffs
> -----
> 
>   kjs/grammar.h 2a006df 
>   kjs/grammar.cpp 32dbeae 
>   kjs/grammar.y d5e835f 
> 
> Diff: http://git.reviewboard.kde.org/r/104243/diff/
> 
> 
> Testing
> -------
> 
> Tested with ecmascript262, all keyword cases pass now, except the reserved ones
> 
> 
> Thanks,
> 
> Bernd Buschinski
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120426/b407f00d/attachment.htm>