Review Request: Make nepomuk runner remove undesired matches

[Lamarque Vieira Souza]

> On April 15, 2012, 5:21 p.m., Sebastian Trueg wrote:
> > This is actually a bug that needs to be addressed differently. Your solution is simply a hack. Normally Nepomuk should not return those results at all. The question is though: why does it? Only if we figure that out we can fix it properly.
> 
> Lamarque Vieira Souza wrote:
>     I have no idea why nepomuk returns those items, it also does it in Plasma Desktop 4.8.2 (search for the word 'document'). I am not an expert in nepomuk and it is very complicated to debug nepomuk's internals. If you have a better idea on how to prevent those items from showing up in query results I am all ears.
> 
> Sebastian Trueg wrote:
>     I know where the problem would be located. However, I cannot reproduce it with 4.8.x.
> 
> Lamarque Vieira Souza wrote:
>     I can reproduce this in my notebook if I use the "Search and Launch" desktop layout and search for "document". The undesired matches returned in the Plasma Active image are different from the ones in my notebook. In my notebook running Gentoo, kde sc 4.8.2 (Qt 4.8.1 if that matters) nepomuk returns matches "Document" (3 times), "Blog Post", "Contract", DocumentGraph", "Logical Media Type", "Topic", "referrencing occurrence" and "serialization language". The ones I cited in this review description are from the Plasma Active image, which uses master branch of the kde sc repos.

Where do you think the problem is located? I cannot reproduce this problem with kde sc 4.8.0 with Qt 4.7.4 in my old notebook but I can in my new notebook with kde sc 4.8.2 and Qt 4.8.1 as I wrote before.


- Lamarque Vieira


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104526/#review12482
-----------------------------------------------------------


On April 9, 2012, 10:29 p.m., Lamarque Vieira Souza wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104526/
> -----------------------------------------------------------
> 
> (Updated April 9, 2012, 10:29 p.m.)
> 
> 
> Review request for KDE Runtime.
> 
> 
> Description
> -------
> 
> Nepomuk runner returns matches like "global namespace", "local namespace" and "PaginatedTextDocument" which pollutes the query's returned matches. This patch adds a NegationTerm to the nepomuk query to filter them. If somebody has a better way to prevent those matches from appearing please let me know.
> 
> 
> This addresses bug 284553.
>     http://bugs.kde.org/show_bug.cgi?id=284553
> 
> 
> Diffs
> -----
> 
>   plasma/generic/runners/nepomuksearch/queryclientwrapper.h 48c1eaa 
>   plasma/generic/runners/nepomuksearch/queryclientwrapper.cpp 0b828b0 
> 
> Diff: http://git.reviewboard.kde.org/r/104526/diff/
> 
> 
> Testing
> -------
> 
> Works in my Plasma Active installation.
> 
> 
> Thanks,
> 
> Lamarque Vieira Souza
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120423/edb2b83a/attachment.htm>