<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/104526/">http://git.reviewboard.kde.org/r/104526/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On April 15th, 2012, 5:21 p.m., <b>Sebastian Trueg</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This is actually a bug that needs to be addressed differently. Your solution is simply a hack. Normally Nepomuk should not return those results at all. The question is though: why does it? Only if we figure that out we can fix it properly.</pre>
</blockquote>
<p>On April 16th, 2012, 2:20 a.m., <b>Lamarque Vieira Souza</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I have no idea why nepomuk returns those items, it also does it in Plasma Desktop 4.8.2 (search for the word 'document'). I am not an expert in nepomuk and it is very complicated to debug nepomuk's internals. If you have a better idea on how to prevent those items from showing up in query results I am all ears.</pre>
</blockquote>
<p>On April 16th, 2012, 8:45 a.m., <b>Sebastian Trueg</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I know where the problem would be located. However, I cannot reproduce it with 4.8.x.</pre>
</blockquote>
<p>On April 16th, 2012, 11:13 a.m., <b>Lamarque Vieira Souza</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I can reproduce this in my notebook if I use the "Search and Launch" desktop layout and search for "document". The undesired matches returned in the Plasma Active image are different from the ones in my notebook. In my notebook running Gentoo, kde sc 4.8.2 (Qt 4.8.1 if that matters) nepomuk returns matches "Document" (3 times), "Blog Post", "Contract", DocumentGraph", "Logical Media Type", "Topic", "referrencing occurrence" and "serialization language". The ones I cited in this review description are from the Plasma Active image, which uses master branch of the kde sc repos.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Where do you think the problem is located? I cannot reproduce this problem with kde sc 4.8.0 with Qt 4.7.4 in my old notebook but I can in my new notebook with kde sc 4.8.2 and Qt 4.8.1 as I wrote before.</pre>
<br />
<p>- Lamarque Vieira</p>
<br />
<p>On April 9th, 2012, 10:29 p.m., Lamarque Vieira Souza wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Runtime.</div>
<div>By Lamarque Vieira Souza.</div>
<p style="color: grey;"><i>Updated April 9, 2012, 10:29 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Nepomuk runner returns matches like "global namespace", "local namespace" and "PaginatedTextDocument" which pollutes the query's returned matches. This patch adds a NegationTerm to the nepomuk query to filter them. If somebody has a better way to prevent those matches from appearing please let me know.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Works in my Plasma Active installation.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=284553">284553</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasma/generic/runners/nepomuksearch/queryclientwrapper.h <span style="color: grey">(48c1eaa)</span></li>
<li>plasma/generic/runners/nepomuksearch/queryclientwrapper.cpp <span style="color: grey">(0b828b0)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/104526/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>