Exposing KSSL in KIO

[Thiago Macieira]

On domingo, 8 de abril de 2012 01.55.06, George Kiagiadakis wrote:
> On Sat, Apr 7, 2012 at 5:54 PM, Thiago Macieira <thiago at kde.org> wrote:
> > On sábado, 7 de abril de 2012 14.25.10, Sune Vuorela wrote:
> >> On 2012-04-06, Thiago Macieira <thiago at kde.org> wrote:
> >> > On sexta-feira, 6 de abril de 2012 01.14.34, David Edmundson wrote:
> >> >> > I don't think so. The classes are likely not to be exported.
> >> >> 
> >> >> Weirdly they are. At least there's a "KIO_EXPORT" in the class
> >> >> definition in the header of KSSLCertificate.
> >> > 
> >> > Then they are exported. I didn't check the file, I just spoke in terms
> >> > of
> >> > likelihood (I can't think of anyone that would want to use them aside
> >> > from
> >> > KIO handling).
> >> > 
> >> > If they are exported, you might be able to do what you want.
> >> 
> >> but please please pretty please don't.   if headers aren't installed it
> >> is not public api and then you should stay out of it. really.
> > 
> > Of course, that's implied.
> > 
> > If it's private API, you should not use it. If you insist, then you are
> > linking against something that might change at any minute, from release to
> > release. And distributions might refuse to package your software.
> 
> But, I really really doubt that anybody is going to do any important
> change in the kdelibs 4.x series, especially in this piece of
> obviously dead code that nobody knew it was there, exported. So, I
> suggest that we use it in kde-telepathy and just make an agreement
> that nobody is to touch this code in kdelibs 4.x (which probably
> wouldn't happen anyway), for the next X months/years that it will take
> us before the new shiny frameworks are ready. :)

That change you're proposing is very simple: install the header. From that 
release on, it becomes public API.

PS: it's not dead code, it's in use by the SSL dialogs.

-- 
Thiago Macieira - thiago (AT) macieira.info - thiago (AT) kde.org
   Software Architect - Intel Open Source Technology Center
      PGP/GPG: 0x6EF45358; fingerprint:
      E067 918B B660 DBD1 105C  966C 33F5 F005 6EF4 5358
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 190 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120407/89f7d824/attachment.sig>