Review Request: Do not force lowercase in KFileDialog automatic file name extension

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102632/#review6587
-----------------------------------------------------------

Ship it!


No objection. The mime database is indeed much cleaner now than it was in 2003 (when it was kde-specific, and had lots of uppercase extensions around).

- David


On Sept. 17, 2011, 6:21 a.m., Thomas Friedrichsmeier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102632/
> -----------------------------------------------------------
> 
> (Updated Sept. 17, 2011, 6:21 a.m.)
> 
> 
> Review request for kdelibs, David Faure and Clarence Dang.
> 
> 
> Summary
> -------
> 
> Currently, the "automatically select file name extension" feature of KFileDialog will always lowercase the file extension. I don't know, whether there is a good reason for this (and hence this review request), but it has been that way from the start[1], and so perhaps it has never been the subject of much consideration.
> 
> Either way, there are a few file-name extensions around, where lower-casing is not a terribly good idea. The ones I stumbled across were ".Rhistory" and ".RData", but others may be around, too. So this patch simply does away with lower-casing.
> 
> Looking at my local mime database, the vast majority of globs, there, is listed lowercase, already. In all of these cases, the end result will be the same. Thus, the impact of this change should be very low.
> 
> 
> [1] http://quickgit.kde.org/?p=kdelibs.git&a=commit&h=8ff421d82e756ff5ade25d98cbc0d47e3ac2de29
> 
> 
> Diffs
> -----
> 
>   kfile/kfilewidget.cpp ae5f760a4afecdb444bfe5fa6922a8d02d5f502c 
> 
> Diff: http://git.reviewboard.kde.org/r/102632/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Thomas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20110917/9e973250/attachment.htm>