<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/102632/">http://git.reviewboard.kde.org/r/102632/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">No objection. The mime database is indeed much cleaner now than it was in 2003 (when it was kde-specific, and had lots of uppercase extensions around).</pre>
<br />
<p>- David</p>
<br />
<p>On September 17th, 2011, 6:21 a.m., Thomas Friedrichsmeier wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for kdelibs, David Faure and Clarence Dang.</div>
<div>By Thomas Friedrichsmeier.</div>
<p style="color: grey;"><i>Updated Sept. 17, 2011, 6:21 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Currently, the "automatically select file name extension" feature of KFileDialog will always lowercase the file extension. I don't know, whether there is a good reason for this (and hence this review request), but it has been that way from the start[1], and so perhaps it has never been the subject of much consideration.
Either way, there are a few file-name extensions around, where lower-casing is not a terribly good idea. The ones I stumbled across were ".Rhistory" and ".RData", but others may be around, too. So this patch simply does away with lower-casing.
Looking at my local mime database, the vast majority of globs, there, is listed lowercase, already. In all of these cases, the end result will be the same. Thus, the impact of this change should be very low.
[1] http://quickgit.kde.org/?p=kdelibs.git&a=commit&h=8ff421d82e756ff5ade25d98cbc0d47e3ac2de29</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kfile/kfilewidget.cpp <span style="color: grey">(ae5f760a4afecdb444bfe5fa6922a8d02d5f502c)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/102632/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>