Review Request: Set the properties action fom mainWindow actionCollection

[Alex Fiestas]

> On May 25, 2011, 10:31 a.m., Christoph Feck wrote:
> > What is the status of this review? Has it been submitted? If yes, please close it.
> 
> Alex Fiestas wrote:
>     OMG, didn't got the email from the review :/! will look into this tomorrow and commit/close/whatever needs to be done.
>     
>     Sorry :/

I've marked it as submitted, the change is in KDE/4.7 dunno if I commit it or Peter did, anyway it is there.


- Alex


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101076/#review3510
-----------------------------------------------------------


On April 10, 2011, 9:54 a.m., Alex Fiestas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101076/
> -----------------------------------------------------------
> 
> (Updated April 10, 2011, 9:54 a.m.)
> 
> 
> Review request for KDE Base Apps.
> 
> 
> Summary
> -------
> 
> In order to have a proper kiosk support in dolphin we should use standard actions whether we can. Dolphin does it right but a few exceptions, this try to fix one of those.
> 
> the properties action from items is made by getting it from the mainWindow::actionCollection but the "properties" action from openViewportContextMenu is custom, which bypasses kiosk.
> 
> The patch simply replace the custom properties action and uses the mainWindow::actionCollection one.
> 
> 
> Diffs
> -----
> 
>   dolphin/src/dolphincontextmenu.cpp 0aa82b2 
> 
> Diff: http://git.reviewboard.kde.org/r/101076/diff
> 
> 
> Testing
> -------
> 
> Compare the result of clicking on the Properties custom action and the standard one.
> 
> 
> Thanks,
> 
> Alex
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20110904/b380cd4d/attachment.htm>