Review Request: systemsettings/fonts: DPI setting is X11-only

Lukas Sommer sommerluk at gmail.com
Sun Sep 4 10:37:34 BST 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102527/
-----------------------------------------------------------

Review request for KDE Base Apps, KDE Runtime and kdewin.


Summary
-------

In systemsettings/fonts, the DPI setting affects only X11. Therefor, this setting should only be enabled when compiling on X11 (and not for compiling on MS Windows or other non-X11 window systems).


Diffs
-----

  kcontrol/fonts/fonts.h 7f1c2d0 
  kcontrol/fonts/fonts.cpp 5a1728d 

Diff: http://git.reviewboard.kde.org/r/102527/diff


Testing
-------

Tested on X11, adding an "#undef Q_WS_X11" for testing purpose.


Thanks,

Lukas

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20110904/7e941ac9/attachment.htm>


More information about the kde-core-devel mailing list