Review Request: Make mouse cursor size configurable

[Lukas Sommer]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101701/
-----------------------------------------------------------

(Updated Sept. 2, 2011, 4:37 p.m.)


Review request for KDE Base Apps, KDE Runtime, kdelibs, and Christoph Feck.


Changes
-------

Uploading a new patch, observing all the comments made until now.


Summary
-------

X11 mouse cursor themes can contain cursors in multiple sizes, making them pseudo-scalable.

It is yet possible in KDE to configure manually the mouse cursor size (editing kcminput.rc). However, the GUI of the corresponding KControl module didn't provide support to change this. This patch add support for changing the mouse cursor size to the GUI.

This are mostly GUI related changes. The underlying data structure XCursorTheme did yet provide support for choosing different sizes and only needed some adjustments.


This addresses bug 90444.
    http://bugs.kde.org/show_bug.cgi?id=90444


Diffs (updated)
-----

  kcontrol/input/xcursor/cursortheme.h 586ccba 
  kcontrol/input/xcursor/cursortheme.cpp 92abea5 
  kcontrol/input/xcursor/legacytheme.h 846bf9b 
  kcontrol/input/xcursor/previewwidget.h f4d2c4e 
  kcontrol/input/xcursor/previewwidget.cpp 3c264fc 
  kcontrol/input/xcursor/themepage.h 38ca893 
  kcontrol/input/xcursor/themepage.cpp 6c9f29a 
  kcontrol/input/xcursor/themepage.ui 2e38054 
  kcontrol/input/xcursor/xcursortheme.h b474086 
  kcontrol/input/xcursor/xcursortheme.cpp 2ecb9ba 

Diff: http://git.reviewboard.kde.org/r/101701/diff


Testing
-------

Tested locally. Works fine for me. Also when using non-standard font DPI values.


Screenshots
-----------


  http://git.reviewboard.kde.org/r/101701/s/188/

  http://git.reviewboard.kde.org/r/101701/s/189/


Thanks,

Lukas

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20110902/a0ac4d3f/attachment.htm>