Review Request: Support passing an argument to the Locale KCM tab to specify which tab to activate at load.

[David Edmundson]

> On Oct. 23, 2011, 5:49 p.m., John Layt wrote:
> > Hi Dave, as maintainer of the Locale KCM I'm happy for this to go in, but we do need to make the command line option consistent for all the KCM's. I suggest checking with Ben Cooksley who is overall maintainer of System Settings as to what he prefers.  Personally, I don't like "--tab=" as the option as the visual implementation may change from a tabbed widget, perhaps "section" or "category" or something similar would be better.  Thanks for doing this!  John.

Feedback from Ben:


"I don't have an opinion as such, but whatever is implemented
absolutely needs to be consistent across all modules which implement
this functionality.

Given that one module already uses --tab, it is probably best to use that."

I'll make that change unless you have any further comments? I'm happy to change kcm_keyboard to support two different arguments if you wanted to move forward with --section (or equivalent)


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102947/#review7560
-----------------------------------------------------------


On Oct. 23, 2011, 10:36 a.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102947/
> -----------------------------------------------------------
> 
> (Updated Oct. 23, 2011, 10:36 a.m.)
> 
> 
> Review request for KDE Runtime.
> 
> 
> Description
> -------
> 
> Part 1/2 of fixing https://bugs.kde.org/show_bug.cgi?id=284755
> 
> Allows programs opening the locale KCM tab to specify which tab the KCM should open on.
> If no arguments are passed then behaviour is as normal.
> 
> 
> Diffs
> -----
> 
>   kcontrol/locale/kcmlocale.cpp 7eb6353 
> 
> Diff: http://git.reviewboard.kde.org/r/102947/diff/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20111026/7a7673ff/attachment.htm>