<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/102947/">http://git.reviewboard.kde.org/r/102947/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On October 23rd, 2011, 5:49 p.m., <b>John Layt</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Hi Dave, as maintainer of the Locale KCM I'm happy for this to go in, but we do need to make the command line option consistent for all the KCM's. I suggest checking with Ben Cooksley who is overall maintainer of System Settings as to what he prefers. Personally, I don't like "--tab=" as the option as the visual implementation may change from a tabbed widget, perhaps "section" or "category" or something similar would be better. Thanks for doing this! John.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Feedback from Ben:
"I don't have an opinion as such, but whatever is implemented
absolutely needs to be consistent across all modules which implement
this functionality.
Given that one module already uses --tab, it is probably best to use that."
I'll make that change unless you have any further comments? I'm happy to change kcm_keyboard to support two different arguments if you wanted to move forward with --section (or equivalent)
</pre>
<br />
<p>- David</p>
<br />
<p>On October 23rd, 2011, 10:36 a.m., David Edmundson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Runtime.</div>
<div>By David Edmundson.</div>
<p style="color: grey;"><i>Updated Oct. 23, 2011, 10:36 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Part 1/2 of fixing https://bugs.kde.org/show_bug.cgi?id=284755
Allows programs opening the locale KCM tab to specify which tab the KCM should open on.
If no arguments are passed then behaviour is as normal.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kcontrol/locale/kcmlocale.cpp <span style="color: grey">(7eb6353)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/102947/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>