Review Request: only install CMakeParseArguments.cmake for cmake versions that do not have it

Ralf Jung ralfjung-e at
Sun Oct 23 16:59:22 BST 2011


> That's the problem.
> CMP0017 should be set to NEW, and it is set to NEW in
> FindKDE4Internal.cmake. So we need to find out why it is not set in this
> case.
Thanks for this hint! After some more debugging, I came up with attached patch 
against kde-workspace which also fixes the warning here (with vanilla kdelibs). 
It seems calling CMAKE_MINIMUM_REQUIRED reset the cmake policy, so the one set 
by FindKDE4 was not applied to this specific subdir. Actually I think the 
"FIND_PACKAGE (Qt4 REQUIRED)" in the same file can also be removed, since this 
is a KDE lib and the upper directories should also have checked for Qt... but 
I do not know why it was added.
Does that look right?

> We haven't been too fast in the past, I don't plan to change that in the
> future :-)
Good to hear :)

Kind regards,
-------------- next part --------------
A non-text attachment was scrubbed...
Name: workspace-fix-warning.diff
Type: text/x-patch
Size: 312 bytes
Desc: not available
URL: <>

More information about the kde-core-devel mailing list