Review Request: rate control in ftp kio slave with review comments fixes

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102307/#review7506
-----------------------------------------------------------


Looks good. Just a few small comments...


kioslave/ftp/ftp.cpp
<http://git.reviewboard.kde.org/r/102307/#comment6490>

    Actually, to avoid detaching, data(QByteArray()) might be faster. But I'm nitpicking, feel free to ignore that :)



kioslave/ftp/ftp.cpp
<http://git.reviewboard.kde.org/r/102307/#comment6489>

    the comment is a bit outdated and unnecessary now. Yes the buffer is empty, there's a clear right above :-)



kioslave/ftp/ratecontroller.h
<http://git.reviewboard.kde.org/r/102307/#comment6488>

    Can you use the kdelibs coding style for new code? That would mean c-basic-offset = 4 (and reindenting the file, not just changing the mode line) :-)



kioslave/ftp/ratecontroller.cpp
<http://git.reviewboard.kde.org/r/102307/#comment6487>

    BTW I fixed that for Qt 5 (usleep is now public) so you can add a "QT5 TODO: remove" comment.


- David Faure


On Aug. 11, 2011, 4:16 p.m., Tushar Mehta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102307/
> -----------------------------------------------------------
> 
> (Updated Aug. 11, 2011, 4:16 p.m.)
> 
> 
> Review request for kdelibs, Dawit Alemayehu, David Faure, Thiago Macieira, Thomas Zander, and Lukas Appelhans.
> 
> 
> Description
> -------
> 
> This patch is trying to clear the comments of the previous patch.(https://git.reviewboard.kde.org/r/102307/)
> 
> 
> Diffs
> -----
> 
>   kioslave/ftp/CMakeLists.txt e080b02 
>   kioslave/ftp/ftp.cpp 655524a 
>   kioslave/ftp/ratecontroller.h PRE-CREATION 
>   kioslave/ftp/ratecontroller.cpp PRE-CREATION 
>   kioslave/ftp/speedController.h PRE-CREATION 
>   kioslave/ftp/speedController.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/102307/diff/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Tushar Mehta
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20111020/aca54a96/attachment.htm>