Review Request: SOCKS proxy support for FTP ioslave

[Dawit Alemayehu]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102923/
-----------------------------------------------------------

Review request for kdelibs and Thiago Macieira.


Description
-------

This patch implements the following two things in kio_ftp:

#1. SOCKS proxy support.
#2. Support for handling multiple proxy server addresses, aka PAC script support.

NOTE: I had to modify the KSocketFactory::proxyFor* functions to return QNetworkProxy::DefaultProxy in order to ensure that setting the application proxy using QNetworkProxy::setApplicationProxy works in kio_ftp.


Diffs
-----

  kdecore/network/ksocketfactory.cpp 2fd63d3 
  kioslave/ftp/ftp.h 0bd375b 
  kioslave/ftp/ftp.cpp 655524a 

Diff: http://git.reviewboard.kde.org/r/102923/diff/diff


Testing
-------

- Tested using the poor man's SOCKS proxy server, ssh -D <port-number> 127.0.0.1.
- Also tested without enabling proxy to check for regression.


Thanks,

Dawit Alemayehu

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20111020/e7cd5f78/attachment.htm>