Review Request: SOCKS proxy support for FTP ioslave

Dawit Alemayehu adawit at
Thu Oct 20 04:59:14 BST 2011

This is an automatically generated e-mail. To reply, visit:

Review request for kdelibs and Thiago Macieira.


This patch implements the following two things in kio_ftp:

#1. SOCKS proxy support.
#2. Support for handling multiple proxy server addresses, aka PAC script support.

NOTE: I had to modify the KSocketFactory::proxyFor* functions to return QNetworkProxy::DefaultProxy in order to ensure that setting the application proxy using QNetworkProxy::setApplicationProxy works in kio_ftp.


  kdecore/network/ksocketfactory.cpp 2fd63d3 
  kioslave/ftp/ftp.h 0bd375b 
  kioslave/ftp/ftp.cpp 655524a 



- Tested using the poor man's SOCKS proxy server, ssh -D <port-number>
- Also tested without enabling proxy to check for regression.


Dawit Alemayehu

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>

More information about the kde-core-devel mailing list