Review Request: only install CMakeParseArguments.cmake for cmake versions that do not have it

[Ralf Jung]

> On Oct. 16, 2011, 9:43 a.m., Alexander Neundorf wrote:
> > Please don't commit this.
> > This is on purpose.
> > We install a file which includes CMakeParseArguments.cmake, so we *must* also install CMakeParseArguments.cmake itself, otherwise we may get in trouble if the version in cmake changes.
> > 
> > Alex

The problem is that this results in a warning about CMake files being overridden when running cmake for kde-workspace. Plus, the files is not even exactly the same as the CMakeParseArgument.cmake that is shipped with my cmake version - it is missing the double-include guard.

If you do not want to use the system version of the file even if it exists, then why not rename this file to KDEParseAguments and fix the cmake files using it? After all you obviously don't even want the behaviour of the cmake default version, but specifically the behaviour of the version shipped in kdelibs. So there is no need to make the filename collide with the "official" version.

I could write up such a patch - is FindPackageHandleStandardArgs.cmake the only user?


- Ralf


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102869/#review7375
-----------------------------------------------------------


On Oct. 15, 2011, 2:47 p.m., Ralf Jung wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102869/
> -----------------------------------------------------------
> 
> (Updated Oct. 15, 2011, 2:47 p.m.)
> 
> 
> Review request for kdelibs.
> 
> 
> Description
> -------
> 
> Only install CMakeParseArguments.cmake for cmake versions that do not have it.
> This fixes a warning when running cmake for kde-workspace, because the same file is shipped by cmake and installed into a modules folder.
> 
> 
> Diffs
> -----
> 
>   cmake/modules/CMakeLists.txt 65379db 
> 
> Diff: http://git.reviewboard.kde.org/r/102869/diff/diff
> 
> 
> Testing
> -------
> 
> re-ran cmake and "make install" for kdelibs and kde-workspace, all working fine and the file is no longer installed (I am using cmake 2.8.5)
> 
> 
> Thanks,
> 
> Ralf Jung
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20111016/0982516b/attachment.htm>