Review Request: only install CMakeParseArguments.cmake for cmake versions that do not have it

Alexander Neundorf neundorf at kde.org
Sun Oct 16 10:43:48 BST 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102869/#review7375
-----------------------------------------------------------


Please don't commit this.
This is on purpose.
We install a file which includes CMakeParseArguments.cmake, so we *must* also install CMakeParseArguments.cmake itself, otherwise we may get in trouble if the version in cmake changes.

Alex

- Alexander Neundorf


On Oct. 15, 2011, 2:47 p.m., Ralf Jung wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102869/
> -----------------------------------------------------------
> 
> (Updated Oct. 15, 2011, 2:47 p.m.)
> 
> 
> Review request for kdelibs.
> 
> 
> Description
> -------
> 
> Only install CMakeParseArguments.cmake for cmake versions that do not have it.
> This fixes a warning when running cmake for kde-workspace, because the same file is shipped by cmake and installed into a modules folder.
> 
> 
> Diffs
> -----
> 
>   cmake/modules/CMakeLists.txt 65379db 
> 
> Diff: http://git.reviewboard.kde.org/r/102869/diff/diff
> 
> 
> Testing
> -------
> 
> re-ran cmake and "make install" for kdelibs and kde-workspace, all working fine and the file is no longer installed (I am using cmake 2.8.5)
> 
> 
> Thanks,
> 
> Ralf Jung
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20111016/1605afcf/attachment.htm>


More information about the kde-core-devel mailing list