Review Request: Proxy overhaul Part 6: Proxy Configuration dialog rewrite

[Dawit Alemayehu]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102802/
-----------------------------------------------------------

(Updated Oct. 14, 2011, 8:38 p.m.)


Review request for KDE Base Apps.


Description
-------

This patch completely overhauls the proxy configuration dialog so that it is much simpler to use and maintain. The major difference between it and the old configuration dialog is the merging of the configuration dialogs for the different proxy types into the main proxy dialog and the addition of a new input for specifying SOCKS proxy settings. See the attached screenshots to see how the new dialog looks.


This addresses bugs 82352, 139789, 142562, 145006, 147340, 164460, 189019, 190149, 190901, 205594, 258196, and 283226.
    http://bugs.kde.org/show_bug.cgi?id=82352
    http://bugs.kde.org/show_bug.cgi?id=139789
    http://bugs.kde.org/show_bug.cgi?id=142562
    http://bugs.kde.org/show_bug.cgi?id=145006
    http://bugs.kde.org/show_bug.cgi?id=147340
    http://bugs.kde.org/show_bug.cgi?id=164460
    http://bugs.kde.org/show_bug.cgi?id=189019
    http://bugs.kde.org/show_bug.cgi?id=190149
    http://bugs.kde.org/show_bug.cgi?id=190901
    http://bugs.kde.org/show_bug.cgi?id=205594
    http://bugs.kde.org/show_bug.cgi?id=258196
    http://bugs.kde.org/show_bug.cgi?id=283226


Diffs
-----

  konqueror/settings/kio/CMakeLists.txt e5476c9 
  konqueror/settings/kio/envvarproxy.ui a09450d 
  konqueror/settings/kio/kenvvarproxydlg.h c7d2f5f 
  konqueror/settings/kio/kenvvarproxydlg.cpp ef5c86c 
  konqueror/settings/kio/kmanualproxydlg.h 4efa63c 
  konqueror/settings/kio/kmanualproxydlg.cpp 6760957 
  konqueror/settings/kio/kproxydlg.h b2cafb8 
  konqueror/settings/kio/kproxydlg.cpp 2f512ce 
  konqueror/settings/kio/kproxydlg.ui 96ff996 
  konqueror/settings/kio/kproxydlgbase.h 2047b90 
  konqueror/settings/kio/kproxydlgbase.cpp 9933698 
  konqueror/settings/kio/ksaveioconfig.h e895c2c 
  konqueror/settings/kio/ksaveioconfig.cpp 62852fa 
  konqueror/settings/kio/manualproxy.ui c69047f 

Diff: http://git.reviewboard.kde.org/r/102802/diff/diff


Testing
-------

- Configure proxy through dialog and validate the results by checking the settings saved in $KDEHOME/share/config/kioslaverc.
- Reloading the proxy dialog to see the saved information is properly loaded back again.


Screenshots (updated)
-----------

No Proxy
  http://git.reviewboard.kde.org/r/102802/s/296/
PAC Proxy
  http://git.reviewboard.kde.org/r/102802/s/297/
System Proxy
  http://git.reviewboard.kde.org/r/102802/s/298/
Manual Proxy
  http://git.reviewboard.kde.org/r/102802/s/301/
Alternate dialog with all options visible
  http://git.reviewboard.kde.org/r/102802/s/303/


Thanks,

Dawit Alemayehu

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20111014/26e3aa10/attachment.htm>