Review Request: facePerm is a KDM option, unrelated to the user setting his face (for other apps)

Oswald Buddenhagen ossi at kde.org
Thu Oct 13 23:37:58 BST 2011


On Thu, Oct 13, 2011 at 06:27:45PM -0400, Steven Sroka wrote:
> >On 13 October 2011 16:53, Ralf Jung <ralfjung-e at gmx.de> wrote:
> >> No tabs, 4 spaces instead.
> >>
> >> http://techbase.kde.org/Policies/Kdelibs_Coding_Style
> > Almost the complete main.cpp is using tabs currently (except for
> > KCMUserAccount::decodeImgDrop, which uses 2 spaces) so I used it for the two
> > lines I added. Is that okay, or am I supposed to use 4 spaces nevertheless?
> 
oh, well, just leave it as-is.

> It's up to the maintainer of the code to accept your code ...
> 
which maintainer, i wonder ... by appearances, it would be scripty.

> Upload a new version of your patch but with only style changes.
> 
only if you are really bored ...




More information about the kde-core-devel mailing list