Requesting freeze exception for JtG
Pau Garcia i Quiles
pgquiles at elpauer.org
Tue Nov 22 23:28:07 GMT 2011
On Tue, Nov 22, 2011 at 10:58 PM, Richard Moore <richmoore44 at gmail.com> wrote:
> I've read over the code changes for this, and it seems to be quite a
> bit more invasive than a simple addition to the about dialog:
> 1) Changes to ui_standards.rc
> This is a high-risk change. It affects every application that uses
> XMLGUI and KParts plugins. I did quite a lot of work in this area in
> KDE 3.x and I know that changes to this file could have a lot of
> knock-on effects regarding gui merging at the time. I don't know if
> this is still the case, but it's a big concern IMHO.
Now that we have established that there might be a risk (I took care
of not breaking anything, but you can never double-check enough),
could you please check the patch does not break anything? I'd like to
move forward as soon as possible so that the strings can be
> 2) Addition of strings and keyboard shortcuts
> This is basically addressed by the request to break the string freeze.
So far (less than 24 hours after asking for the freeze exception),
four teams have said "yes", none has said "no". I'd say the message
freeze is not an issue (after all, the new text is less than 100
> 3) Maturity of the code
> This code according to git is less than a day old. How much testing has it seen?
The root cause for the patch only arose on Saturday afternoon, and I
developed the code on Sunday morning. Review with Lydia, Claudia,
Stuart and Frank, pictures, icons, travel back to Spain, etc took some
time. That's why the code is so young.
Testing? "It works for me". It should not break anything, though. And
I'd say the more the code takes to be merged into kdelibs, the less
testing it will see.
> I really don't see that this code can be accepted as-is. A simpler
> change like adding a join the game tab to the about dialog would be
> much less invasive, has this been considered? If so, why was it
It was considered and rejected exactly because it was much less
invasive. We want to make sure Join the Game is seen. A new tab in the
(already overcrowded) About KDE dialog was not an option. In fact, I
renamed two of the tabs in About KDE to make sure there will be no
chance of confusion with Join the Game.
In fact, if it were not for the freeze, I would have considered adding
Join the Game to KTipDialog too.
Pau Garcia i Quiles
(Due to my workload, I may need 10 days to answer)
More information about the kde-core-devel