Review Request: Add fromTheme property to QIconItem in QtExtraComponents for theme icons in QML

[Marco Martin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103009/#review7826
-----------------------------------------------------------


to me it would be fine (even tough there are starting to be quite a lot of ways to do icons), the only precondition, apart nitpicks below there are, that it must be tested really well, particularly with:

* icon: QIcon("foo") should still work
* icons coming from a qstandarditemmodel and rendered in a listview with a QIconItem as delegate should still be rendered correctly

this can't go in before those two points, especially the second are verified


plasma/declarativeimports/qtextracomponents/qiconitem.cpp
<http://git.reviewboard.kde.org/r/103009/#comment6757>

    right now kiconloader or better, just just KIcon(icon.toString) is still needed for performance reasons



plasma/declarativeimports/qtextracomponents/qiconitem.cpp
<http://git.reviewboard.kde.org/r/103009/#comment6756>

    whitespace..


- Marco Martin


On Nov. 1, 2011, 6:43 p.m., Mark Gaiser wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103009/
> -----------------------------------------------------------
> 
> (Updated Nov. 1, 2011, 6:43 p.m.)
> 
> 
> Review request for KDE Runtime and Plasma.
> 
> 
> Description
> -------
> 
> Hi,
> 
> I found it very strange that QIcon::fromTheme was "just working". Sadly in KDE's brand new PlasmaComponents it was simply impossible to use the system icons without using plasma to view the QML. This patch adds a property to QIconItem named: "fromTheme" which allows you to get the icons from the theme you currently use. This patch alone isn't helping a lot of people but i have a second patch ready for PlasmaComponents.Button to make use of this.
> 
> Oke to commit?
> 
> 
> Diffs
> -----
> 
>   plasma/declarativeimports/qtextracomponents/qiconitem.h 9972a98 
>   plasma/declarativeimports/qtextracomponents/qiconitem.cpp d72381e 
> 
> Diff: http://git.reviewboard.kde.org/r/103009/diff/diff
> 
> 
> Testing
> -------
> 
> Tested it with a bunch of different icons in and it all just seems to work fine.
> 
> 
> Thanks,
> 
> Mark Gaiser
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20111101/4e5f1e15/attachment.htm>