Review Request: Add fromTheme property to QIconItem in QtExtraComponents for theme icons in QML

[Mark Gaiser]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103009/
-----------------------------------------------------------

(Updated Nov. 1, 2011, 6:43 p.m.)


Review request for KDE Runtime and Plasma.


Changes
-------

Version 2. Using a QVariant.
This seems to work. I tested it for the fromTheme case and that works well. Couldn't test it for the QIcon case though.


Description
-------

Hi,

I found it very strange that QIcon::fromTheme was "just working". Sadly in KDE's brand new PlasmaComponents it was simply impossible to use the system icons without using plasma to view the QML. This patch adds a property to QIconItem named: "fromTheme" which allows you to get the icons from the theme you currently use. This patch alone isn't helping a lot of people but i have a second patch ready for PlasmaComponents.Button to make use of this.

Oke to commit?


Diffs (updated)
-----

  plasma/declarativeimports/qtextracomponents/qiconitem.h 9972a98 
  plasma/declarativeimports/qtextracomponents/qiconitem.cpp d72381e 

Diff: http://git.reviewboard.kde.org/r/103009/diff/diff


Testing
-------

Tested it with a bunch of different icons in and it all just seems to work fine.


Thanks,

Mark Gaiser

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20111101/320ade9c/attachment.htm>
-------------- next part --------------
_______________________________________________
Plasma-devel mailing list
Plasma-devel at kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel