Review Request: [PATCH] Change HTML thumbnail generator to use kdewebkit to fix bug 248478
Dawit Alemayehu
adawit at kde.org
Fri May 27 22:57:36 BST 2011
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101365/
-----------------------------------------------------------
(Updated May 27, 2011, 9:57 p.m.)
Review request for KDE Runtime.
Summary (updated)
-------
The attached patch fixes the html thumbnail generator so that it won't show the "Open With" dialog box whenever it encounters frames and other content such as flash.
Please note that I changed the engine not because of ideological preference, but rather because I cannot figure out how to fix it with khtml.
This addresses bug 248478.
http://bugs.kde.org/show_bug.cgi?id=248478
Diffs
-----
kioslave/thumbnail/CMakeLists.txt 9789109
kioslave/thumbnail/htmlcreator.h 6903db7
kioslave/thumbnail/htmlcreator.cpp c623606
Diff: http://git.reviewboard.kde.org/r/101365/diff
Testing
-------
Thanks,
Dawit
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20110527/705a7fb4/attachment.htm>
More information about the kde-core-devel
mailing list