Review Request: Fix the html thumbnail generator's inability to properly handle frames and other embeded content

Dawit Alemayehu adawit at
Sun May 15 06:27:33 BST 2011

This is an automatically generated e-mail. To reply, visit:

Review request for KDE Runtime.


The attached patch fixes the html thumbnail generator so that it won't show the "Open With" dialog box whenever it encounters frames and other content such as flash. Please note that the actual fix was to simply switch the rendering engine from khtml to kdewebkit simply because I was unable to figure out how to prevent khtml from doing what was reported in the bug linked above.

This addresses bug 248478.


  kioslave/thumbnail/CMakeLists.txt 9789109 
  kioslave/thumbnail/htmlcreator.h 6903db7 
  kioslave/thumbnail/htmlcreator.cpp c623606 





-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>

More information about the kde-core-devel mailing list