Review Request: Make kdelibs build against qt 4.8 which has added QStringBuilder to QByteArray + operations.

[Olivier Goffart]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101342/#review3302
-----------------------------------------------------------



kdecore/sycoca/ksycocadict.cpp
<http://git.reviewboard.kde.org/r/101342/#comment2773>

    I think the second QByteArray is useless



plasma/tests/plasmoidpackagetest.cpp
<http://git.reviewboard.kde.org/r/101342/#comment2774>

    this is unrelated; but why is there dir.toLatin1(),  it should just be 'dir'
    the toLatin1 seems to be a mistake at a first glance.


- Olivier


On May 12, 2011, 4:01 a.m., Jeremy Paul Whiting wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101342/
> -----------------------------------------------------------
> 
> (Updated May 12, 2011, 4:01 a.m.)
> 
> 
> Review request for kdelibs and David Faure.
> 
> 
> Summary
> -------
> 
> This makes kdelibs build with qt 4.8 (besides the one problem in kio/kio/scheduler.cpp).
> 
> 
> Diffs
> -----
> 
>   kdecore/io/klockfile_unix.cpp 10c9039 
>   kdecore/kernel/kstandarddirs.cpp f5a17aa 
>   kdecore/network/k3socks.cpp ed7eed9 
>   kdecore/sycoca/ksycocadict.cpp 3df7bce 
>   kdeui/kernel/kapplication.cpp 8ec47ca 
>   kdeui/tests/kxmlgui_unittest.cpp f19acc0 
>   kdeui/tests/proxymodeltestapp/modelcommanderwidget.cpp 2ff9332 
>   kdeui/util/kxmessages.cpp 132979d 
>   khtml/java/tests/testkjavaappletserver.cpp 454f832 
>   plasma/private/serviceprovider_p.h 3ce1ba4 
>   plasma/tests/plasmoidpackagetest.cpp 713c400 
> 
> Diff: http://git.reviewboard.kde.org/r/101342/diff
> 
> 
> Testing
> -------
> 
> Built and installed.  Will build the rest of kde tonight and test in the morning.
> 
> 
> Thanks,
> 
> Jeremy Paul
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20110513/2925257d/attachment.htm>