<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/101342/">http://git.reviewboard.kde.org/r/101342/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/101342/diff/1/?file=16353#file16353line522" style="color: black; font-weight: bold; text-decoration: underline;">kdecore/sycoca/ksycocadict.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">KSycocaDict::save(QDataStream &str)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">522</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">QByteArray</span><span class="p">(</span><span class="s">"entry offset is 0, save() was not called on "</span><span class="p">)</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">522</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n"><span class="hl">QByteArray</span></span><span class="p"><span class="hl">(</span></span><span class="n">QByteArray</span><span class="p">(</span><span class="s">"entry offset is 0, save() was not called on "</span><span class="p">)</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I think the second QByteArray is useless</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/101342/diff/1/?file=16360#file16360line54" style="color: black; font-weight: bold; text-decoration: underline;">plasma/tests/plasmoidpackagetest.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void PlasmoidPackageTest::cleanup()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">54</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">removeDir</span><span class="p">(</span><span class="n">QLatin1String</span><span class="p">(</span><span class="s">"packageRoot/"</span> <span class="o">+</span> <span class="n">dir</span><span class="p">.</span><span class="n">toLatin1</span><span class="p">()</span> <span class="o">+</span> <span class="s">"/contents/code"</span><span class="p">)<span class="hl">)</span>;</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">54</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">removeDir</span><span class="p">(</span><span class="n">QLatin1String</span><span class="p">(</span><span class="s">"packageRoot/"</span><span class="p"><span class="hl">)</span></span> <span class="o">+</span> <span class="n">dir</span><span class="p">.</span><span class="n">toLatin1</span><span class="p">()</span> <span class="o">+</span> <span class="s">"/contents/code"</span><span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">this is unrelated; but why is there dir.toLatin1(), it should just be 'dir'
the toLatin1 seems to be a mistake at a first glance.</pre>
</div>
<br />
<p>- Olivier</p>
<br />
<p>On May 12th, 2011, 4:01 a.m., Jeremy Paul Whiting wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for kdelibs and David Faure.</div>
<div>By Jeremy Paul Whiting.</div>
<p style="color: grey;"><i>Updated May 12, 2011, 4:01 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This makes kdelibs build with qt 4.8 (besides the one problem in kio/kio/scheduler.cpp).</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Built and installed. Will build the rest of kde tonight and test in the morning.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kdecore/io/klockfile_unix.cpp <span style="color: grey">(10c9039)</span></li>
<li>kdecore/kernel/kstandarddirs.cpp <span style="color: grey">(f5a17aa)</span></li>
<li>kdecore/network/k3socks.cpp <span style="color: grey">(ed7eed9)</span></li>
<li>kdecore/sycoca/ksycocadict.cpp <span style="color: grey">(3df7bce)</span></li>
<li>kdeui/kernel/kapplication.cpp <span style="color: grey">(8ec47ca)</span></li>
<li>kdeui/tests/kxmlgui_unittest.cpp <span style="color: grey">(f19acc0)</span></li>
<li>kdeui/tests/proxymodeltestapp/modelcommanderwidget.cpp <span style="color: grey">(2ff9332)</span></li>
<li>kdeui/util/kxmessages.cpp <span style="color: grey">(132979d)</span></li>
<li>khtml/java/tests/testkjavaappletserver.cpp <span style="color: grey">(454f832)</span></li>
<li>plasma/private/serviceprovider_p.h <span style="color: grey">(3ce1ba4)</span></li>
<li>plasma/tests/plasmoidpackagetest.cpp <span style="color: grey">(713c400)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/101342/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>