Review Request: Fix the layout of KNameAndUrlInputDialog (kfile)

Jonathan Marten jjm at
Sun May 8 07:29:39 BST 2011

This is an automatically generated e-mail. To reply, visit:

Review request for kdelibs.


This dialogue - used, for example, for the desktop's "Create New - Link to Location" or "Create New - Basic link to" actions, has a very ugly layout where the labels are squashed up to the entry fields and the two lines are not vertically aligned with each other.  This change uses a form layout instead, which automatically adopts the standard KDE style and spacing.

In addition to the layout, the "OK" button is enabled when the dialogue is first shown; it should not be because the two entry fields are empty. This is checked at the end of the constructor.


  kfile/knameandurlinputdialog.cpp fd02af6 



Built kdelibs with these changes, checked operation and appearance of dialogue via Plasma desktop.



-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>

More information about the kde-core-devel mailing list