Review Request: kJ/mol for the kUnitConversion class

Petri Damstén petri.damsten at kdemail.net
Thu Mar 31 08:43:57 BST 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100977/#review2268
-----------------------------------------------------------

Ship it!


Looks good.

- Petri


On March 30, 2011, 8:58 p.m., Etienne Rebetez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100977/
> -----------------------------------------------------------
> 
> (Updated March 30, 2011, 8:58 p.m.)
> 
> 
> Review request for kdelibs.
> 
> 
> Summary
> -------
> 
> Hi,
> 
> Again some missing Units needed for kalzium. I added kJ/mol and J/mol to the energy class.
> These units are related to the electron volt. http://en.wikipedia.org/wiki/Electronvolt
> 
> Thanks 
> 
> 
> Diffs
> -----
> 
>   kunitconversion/converter.h 0b39ddd 
>   kunitconversion/energy.cpp 27b76f6 
> 
> Diff: http://git.reviewboard.kde.org/r/100977/diff
> 
> 
> Testing
> -------
> 
> Conversion from eV to kJ/mol with kunitconversion has same result as the old kalzium "unitconversion" algorithm.
> 
> 
> Thanks,
> 
> Etienne
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20110331/5ea6194e/attachment.htm>


More information about the kde-core-devel mailing list