Review Request: KNS overwrites existing files automatically on an update

[Jeremy Paul Whiting]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100961/#review2211
-----------------------------------------------------------

Ship it!


This looks good, ship it.

- Jeremy Paul


On March 27, 2011, 5:13 p.m., Matthias Fuchs wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100961/
> -----------------------------------------------------------
> 
> (Updated March 27, 2011, 5:13 p.m.)
> 
> 
> Review request for kdelibs and Frederik Gladhorn.
> 
> 
> Summary
> -------
> 
> The existing code already suggests that the user should not be asked for overwriting files if they do an update.
> This patch makes this finally work now by looking if the status is Entry::Updating.
> 
> 
> Diffs
> -----
> 
>   knewstuff/knewstuff3/core/installation.cpp be4ba69 
> 
> Diff: http://git.reviewboard.kde.org/r/100961/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Matthias
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20110329/ca179e23/attachment.htm>