Review Request: Adding Ångström to KUnitConversion

[Johannes Sixt]

Am 3/22/2011 23:14, schrieb Parker Coates:
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100923/
> 
> 
> kunitconversion/length.cpp
> <http://git.reviewboard.kde.org/r/100923/diff/1/?file=12695#file12695line146>
> (Diff revision 1)
> 
> Length::Length() : UnitCategory(LengthCategory)
> 
> 	
> 
> 	146 	
> 
>       i18nc("unit synonyms for matching user input", "Ångström;Ångstrom;Angström,Å"),

What is the encoding of this string? What is the encoding of the source
file? I guess this is a latin1 string; shouldn't you better write the
string as

"\xc5ngstr\xf6m;\xc5ngstrom;Angstr\xf6m;Angstrom;\xc5"

to avoid any encoding errors? (Also, did you mean ; instead of , before
the final Å?)

> 
> You missed "Angstrom". Accents are too hard for some of us. :) Plural forms might be good too.

Hannes
-- 
"Atomic objects are neither active nor radioactive." --
Programming Languages -- C++, Final Committee Draft (Doc.N3092)