Review Request: Move the KPasswordDialog "Anonymous" checkbox below the input boxes...

Dawit Alemayehu adawit at kde.org
Wed Mar 23 04:20:30 GMT 2011



> On March 22, 2011, 6:23 p.m., John Layt wrote:
> > My thoughts are if the anonymous tickbox is first focus it should be above the username/password fields and the username/password fields should be disabled if anonymous is selected.  But that may look a little weird with the text to the left and the title below it.
> > 
> > Or does entering a username/password automatically de-select the anonymous?  In which case this is fine so long as the username field has the cursor focus and pressing enter immediately activates the ok button.  
> > 
> > Or perhaps pre-populate username with 'anonymous' and have the word pre-selected so it can be overtyped and do away with the tickbox entirely?
> > 
> > Basically what I'm looking for is the easiest shortest most obvious path for the main use cases.
> > 
> > </bikeshedding>
> 
> Thomas L├╝bking wrote:
>     > the anonymous tickbox is first focus it should be above the username/password
>     +1
>     
>     > username/password fields should be disabled if anonymous is selected
>     the problem is about checking the box will disable the UI.
>     
>     can we maybe drop the checkbox entirely and just QLinedit::setPlaceholderText("anonymous")  and QLinedit::setPlaceholderText("no password required for anonymous login") or sth. like this?
>     
>     The tab order can btw be controlled explicitly and unrelated to the actual layout.

> Or does entering a username/password automatically de-select the anonymous?  In which case this is fine so long as the username field has the cursor focus and pressing enter
> immediately activates the ok button.

Nope. You have to manually deselect the checkbox to enter the username/password. Otherwise, those input widgets will be set to read only.

> Basically what I'm looking for is the easiest shortest most obvious path for the main use cases.

Unfortunately, that is the problem. This feature does not solve any main use case. Rather it seems to have been added to deal with a very corner case in specific ioslaves, ftp being the main or only?? one.

> can we maybe drop the checkbox entirely and just QLinedit::setPlaceholderText("anonymous")  and QLinedit::setPlaceholderText("no password required for anonymous
> login") or sth. like this?

Well, it seems that the anonymous checkbox was specifically added to distinguish between the default "anonymous" login and a user entered "anonymous" user name for the ftp ioslave. At least that is what I get reading the commit message in the ftp ioslave that seems to be related to this checkbox [1]. As such, I fail to see how the placeholder text approach would satisfy what the checkbox is attempting to achieve. However, I personally do not think that checkbox should exist at all. It is there to handle a very corner case for very specific ioslaves (mainly ftp ioslave). Even then it seems to be used incorrectly right now. Anyhow, I like the placeholder idea but I will serve the same purpose as the checkbox.

> The tab order can btw be controlled explicitly and unrelated to the actual layout.

Right, but the checkbox will still look out of place where it is right now.


[1] http://quickgit.kde.org/?p=kdelibs.git&a=commit&h=2e48eecc2fda83f08fb5f55519fe51793f536734


- Dawit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100920/#review2106
-----------------------------------------------------------


On March 22, 2011, 6:04 p.m., Dawit Alemayehu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100920/
> -----------------------------------------------------------
> 
> (Updated March 22, 2011, 6:04 p.m.)
> 
> 
> Review request for kdelibs.
> 
> 
> Summary
> -------
> 
> The attached patch renames and moves the "Anonymous" box shown in the first screenshot below the password input widgets. This change is done to 
> 
> #1. Remove the checkbox from screwing tab order when you enter username/password.
> #2. Make the purpose of the checkbox less cryptic to the end user.
> 
> Any objections ?
> 
> 
> Diffs
> -----
> 
>   kdeui/dialogs/kpassworddialog.ui 2649870 
> 
> Diff: http://git.reviewboard.kde.org/r/100920/diff
> 
> 
> Testing
> -------
> 
> 
> Screenshots
> -----------
> 
> Current Password Dialog
>   http://git.reviewboard.kde.org/r/100920/s/106/
> New Password Dialog
>   http://git.reviewboard.kde.org/r/100920/s/107/
> 
> 
> Thanks,
> 
> Dawit
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20110323/03580298/attachment.htm>


More information about the kde-core-devel mailing list