Review Request: Move the KPasswordDialog "Anonymous" checkbox below the input boxes...

Thomas L├╝bking thomas.luebking at web.de
Tue Mar 22 18:56:17 GMT 2011



> On March 22, 2011, 6:23 p.m., John Layt wrote:
> > My thoughts are if the anonymous tickbox is first focus it should be above the username/password fields and the username/password fields should be disabled if anonymous is selected.  But that may look a little weird with the text to the left and the title below it.
> > 
> > Or does entering a username/password automatically de-select the anonymous?  In which case this is fine so long as the username field has the cursor focus and pressing enter immediately activates the ok button.  
> > 
> > Or perhaps pre-populate username with 'anonymous' and have the word pre-selected so it can be overtyped and do away with the tickbox entirely?
> > 
> > Basically what I'm looking for is the easiest shortest most obvious path for the main use cases.
> > 
> > </bikeshedding>

> the anonymous tickbox is first focus it should be above the username/password
+1

> username/password fields should be disabled if anonymous is selected
the problem is about checking the box will disable the UI.

can we maybe drop the checkbox entirely and just QLinedit::setPlaceholderText("anonymous")  and QLinedit::setPlaceholderText("no password required for anonymous login") or sth. like this?

The tab order can btw be controlled explicitly and unrelated to the actual layout.


- Thomas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100920/#review2106
-----------------------------------------------------------


On March 22, 2011, 6:04 p.m., Dawit Alemayehu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100920/
> -----------------------------------------------------------
> 
> (Updated March 22, 2011, 6:04 p.m.)
> 
> 
> Review request for kdelibs.
> 
> 
> Summary
> -------
> 
> The attached patch renames and moves the "Anonymous" box shown in the first screenshot below the password input widgets. This change is done to 
> 
> #1. Remove the checkbox from screwing tab order when you enter username/password.
> #2. Make the purpose of the checkbox less cryptic to the end user.
> 
> Any objections ?
> 
> 
> Diffs
> -----
> 
>   kdeui/dialogs/kpassworddialog.ui 2649870 
> 
> Diff: http://git.reviewboard.kde.org/r/100920/diff
> 
> 
> Testing
> -------
> 
> 
> Screenshots
> -----------
> 
> Current Password Dialog
>   http://git.reviewboard.kde.org/r/100920/s/106/
> New Password Dialog
>   http://git.reviewboard.kde.org/r/100920/s/107/
> 
> 
> Thanks,
> 
> Dawit
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20110322/510496a4/attachment.htm>


More information about the kde-core-devel mailing list