Review Request: Patch for "FTP ioslave unnecessarily asks for password"

Dawit Alemayehu adawit at kde.org
Sat Mar 19 04:37:59 GMT 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100873/
-----------------------------------------------------------

(Updated March 19, 2011, 4:37 a.m.)


Review request for kdelibs.


Changes
-------

Updated patch based on David's correct observation about the problem with the previous patch.


Summary
-------

The attached patch forces kio_ftp to first look up for cached password before showing the user a prompt to enter password information. This addresses the issue mentioned in 143488 and makes kio_ftp's behavior consistent with the other ioslaves.


This addresses bugs 124675 and 143488.
    http://bugs.kde.org/show_bug.cgi?id=124675
    http://bugs.kde.org/show_bug.cgi?id=143488


Diffs (updated)
-----

  kioslave/ftp/ftp.cpp 95c4450 

Diff: http://git.reviewboard.kde.org/r/100873/diff


Testing
-------

Login to an ftp site, save the password and visit the same site again. No prompt.


Thanks,

Dawit

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20110319/c8473622/attachment.htm>


More information about the kde-core-devel mailing list